Repository navigation
fix(resolve): cache parallel snapshot lookups - #237
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 95.34% 95.35% +0.01%
==========================================
Files 141 141
Lines 79148 79452 +304
==========================================
+ Hits 75464 75765 +301
- Misses 3684 3687 +3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance rationale
On the reported index, the old adjacency setup issued about 750,574 point queries for 375,287 nodes to retrieve 7,715 inheritance edges. The new path issues two indexed queries. Parallel resolution now reads and parses a given source file once per resident cache entry instead of once per unresolved reference.
Validation